saltstack / saltstack/salt

network.system disables interfaces

Open
#42,145 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug severity-medium
Dominant language
Python
Stars
15.7k
Forks
5.6k
Avg merge
2d 44m
Merged PRs (30d)
80

Description

Description of Issue/Question

Spinning up a new minion and applying this state, the network interface is left in a disabled state (as reported by ip addr).

system:
  network.system:
    - enabled: True
    - hostname: {{ grains['id'] }}
    - nozeroconf: True
    - apply_hostname: True

This, of course, makes the rest of the highstate process extremely difficult.

Setup

Minion: Debian Stretch, Salt 2016.11.2, running on VMware ESXi/vSphere, created by salt-cloud (via clone from template)
Master: Debian Jessie, 2016.11.5

(No, I'm not sure why the version discrepancy, since the salt-cloud is invoked on the master.)

Steps to Reproduce Issue
$ salt-cloud -p myprofile myinstance
$ salt myinstance state.apply hostname
Versions Report
Salt Version:
           Salt: 2016.11.5
 
Dependency Versions:
           cffi: 1.9.1
       cherrypy: unknown
       dateutil: 2.5.3
      docker-py: Not Installed
          gitdb: 2.0.0
      gitpython: 2.1.1
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: 1.3.7
      pycparser: 2.17
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.13 (default, Jan 19 2017, 14:48:08)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: 2.0.1
        timelib: Not Installed
        Tornado: 4.4.3
            ZMQ: 4.2.1
 
System Versions:
           dist: debian 9.0 
        machine: x86_64
        release: 4.9.0-3-amd64
         system: Linux
        version: debian 9.0 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the network.system state using enabled, nozeroconf, and apply_hostname, then reproduce it with the listed salt-cloud and state.apply hostname commands on Debian Stretch. Trace the network interface handling before and after the state runs, using ip addr to verify the result. Done means the interface remains enabled and the subsequent highstate can proceed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devops, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.