Different hashtype between master and minion should result in warning
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
I've got a tree that I'm distributing via salt and it makes a highstate run very slow.
static-web:
file.recurse:
- name: /var/www/static/
- source: salt://static_web/ # staat in /home/salt/files
# - clean: true # eens per zoveel tijd runnen want het scheelt een boel
- group: www-data
- dir_mode: 755
- file_mode: 644
- include_empty: true
when I up the log_level to profile:
2016-11-30 14:39:30,662 [salt.state ][INFO ][12520] Completed state [/var/www/static/] at time 14:39:30.662156 duration_in_ms=54343.841
When run over a slow line (4mbit) it is totally unacceptable, highstate times up to 1800 secs.
If I look at the logs it seems that all files are redistributed all the time. This seems to be a regression in 2016.3.4 (my current version), didn't happen before.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the file.recurse highstate from the issue using Salt 2016.3.4, with the shown tree and a slow connection, while reviewing profile-level logs. Compare master and minion hashtypes and determine the expected warning and whether the repeated redistribution is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100