salt-ssh fails if config path contains spaces
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 5.6k
- Avg merge
- 2d 44m
- Merged PRs (30d)
- 80
Description
Expected Behavior
salt-ssh runs and executes commands on minion
Actual Behavior
salt-ssh fails to deploy thin version
Steps to Reproduce Issue
create mini config following guide https://blog.logentries.com/2015/04/salt-ssh-for-remote-execution-of-states-and-modules/. but put it a path containing spaces
turn on debug mode and you will see that it tries to execute a command like
DEBUG ] Executing command: scp -o KbdInteractiveAuthentication=no -o PasswordAuthentication=no -o GSSAPIAuthentication=no -o ConnectTimeout=65 -o Port=22 -o IdentityFile=~/.ssh/id_rsa -o User=root /Users/askholme/Devel/care 2 reuse/infrastructure/salt/var/cache/salt/master/thin/thin.tgz 104.236.216.105:/tmp/.root_5cf76b_salt/salt-thin.tgz
this fails because the local path to thin.tgz is not enclosed in double qoutes.
Versions Report
* Provided by running salt --versions-report*
Salt Version:
Salt: 2015.8.5
Dependency Versions:
Jinja2: 2.8
M2Crypto: 0.21.1
Mako: Not Installed
PyYAML: 3.11
PyZMQ: 15.2.0
Python: 2.7.10 (default, Oct 23 2015, 18:05:06)
RAET: Not Installed
Tornado: 4.3
ZMQ: 4.1.4
cffi: Not Installed
cherrypy: Not Installed
dateutil: 1.5
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
libgit2: Not Installed
libnacl: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.4.6
mysql-python: Not Installed
pycparser: Not Installed
pycrypto: 2.6.1
pygit2: Not Installed
python-gnupg: Not Installed
smmap: Not Installed
timelib: Not Installed
System Versions:
dist:
machine: x86_64
release: 15.2.0
system: 10.11.2 -- x86_64
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the salt-ssh thin deployment path that builds the scp command, then reproduce the issue using a configuration path containing spaces and debug output. Done means salt-ssh deploys the thin version and executes commands successfully with such a path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100