salesforce / salesforce/rules_spring
Use the correct build JDK details when writing the Spring Boot MANIFEST.MF file
Nobody has claimed this yet.
- Dominant language
- Starlark
- Stars
- 257
- Forks
- 58
- PR merge metrics
- No merged PRs in 30d
Description
See write_manifest.sh. It helpfully inscribes the version of the JDK that was used to build the code in the generated Spring Boot application. Unfortunately, the value that is being written today is incorrect in many cases.
We need to inject this information from the actual JDK used to build the source (the toolchain), not the JDK that is in path while the genrule executes.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tools/springboot/write_manifest.sh at line 28 and trace how the generated Spring Boot MANIFEST.MF receives the JDK version. Compare the JDK from the build toolchain with the JDK available on PATH during genrule execution. Done means the manifest records the JDK actually used to build the source.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- spring-boot
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100