salesforce / salesforce/rules_spring
Springboot macro doesn't work with symbolic macros
Open
Nobody has claimed this yet.
2.7.0
bug
- Dominant language
- Starlark
- Stars
- 257
- Forks
- 58
- PR merge metrics
- No merged PRs in 30d
Description
The new Symbolic Macros in Bazel 8 enforce naming conventions that the springboot macro provided by this repo does not adhere to:
ERROR: /Users/tr185153/src/<redacted>/libs/common/bzl/springboot.bzl:23:20: in genrule rule //path/to/target:path/to/target_name_genbazelrunenv: Target //path/to/target:path/to/target_name_genbazelrunenv declared in symbolic macro 'name' violates macro naming rules and cannot be built. Name must be the same as the macro's name, or the macro's name followed by '_' (recommended), '-', or '.', and a non-empty string.
For now I can just use legacy macros, but just wanted to bring this to your attention.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with libs/common/bzl/springboot.bzl at line 23 and compare the generated target name with the Bazel 8 symbolic macro naming rules linked in the issue. Confirm the failure using a symbolic macro invocation; done means the springboot macro no longer produces the reported naming violation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- spring-boot
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100