salesforce / salesforce/design-system-react
Datepicker doesn't update input text when (date) value attribute is provided
Open
Nobody has claimed this yet.
date-picker
needs-clarity
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
The internal date object is updated, but the input value remains the same. The following fix seems to solve the problem:
Add inputValue: this.props.formatter(nextProps.value) as an attribute to the state object being set on https://github.com/salesforce-ux/design-system-react/blob/master/components/date-picker/date-picker.jsx#L274
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in components/date-picker/date-picker.jsx around line 274 and trace how a provided value updates the internal date and input text. Verify the reported case, then confirm that changing the date value also changes the displayed input value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100