salesforce / salesforce/design-system-react
New Modal footer prop
Open
Nobody has claimed this yet.
modal
needs-clarity
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
We should allow something besides an array of buttons to be passed into a modal footer.
<ModalFooter directional>
{children]
</ModalFooter>
directional is a flexbox justify
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ModalFooter entry point and any existing modal footer tests. Read how footer children and layout props are currently handled, then clarify and implement support for non-array children and the intended directional flexbox behavior with coverage for the resulting layout.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100