salesforce / salesforce/design-system-react

Inconsistent date output in Datepicker

Open
#857 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking-change date-picker
Dominant language
JavaScript
Stars
982
Forks
440
Avg merge
1d 21h
Merged PRs (30d)
4

Description

Today is today at current time.

screenshot 2017-01-20 15 20 13

Yesterday is yesterday at midnight.

Probably need to feed midnight into the new Date()call or produce the date with the just days and not time. Or we need to switch everything to midnight on output.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names only the Datepicker and the Today/Yesterday outputs; start by reproducing the screenshot and checking the generated times. Clarify whether output should use midnight or omit time, then verify that both labels follow the chosen rule.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.