salesforce / salesforce/design-system-react
Update react-modal library version from 3.14.3 to 3.16.1
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
Update react-modal library version from 3.14.3 to 3.16.1
When we try to update react version from 17 to 18 then, I get a warning in the console:
npm WARN react-modal@3.14.3 requires a peer of react@^0.14.0 || ^15.0.0 || ^16 || ^17 but none is installed. You must install peer dependencies yourself.
npm WARN react-modal@3.14.3 requires a peer of react-dom@^0.14.0 || ^15.0.0 || ^16 || ^17 but none is installed. You must install peer dependencies yourself.
https://github.com/salesforce/design-system-react/blob/master/package.json#L107
In the latest version, they are supporting react 18 version
https://github.com/reactjs/react-modal/blob/master/package.json#L73
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the react-modal dependency entry in package.json, linked from the issue, and compare it with the react-modal package metadata referenced there. Update the version from 3.14.3 to 3.16.1, then verify that the React 18 peer-dependency warning is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100