salesforce / salesforce/design-system-react
Drop IE11 support and CommonJS?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
IE11 was officially retired by Microsoft in June 2022. Would it be possible to update the list of supported targets here?
Similarly, the library package on npm includes three different unbundled versions of each component:
- Source code in
/components - Compiled ES modules in
/module/components - Compiled CommonJS modules in
/lib/components
There also seem to be several bundled versions of the entire library:
- design-system-react-components.js
- design-system-react-components.min.js
- design-system-react.js
- design-system-react.min.js
While decreasing the size of the npm package would certainly be nice, the main reason that it would be nice to consolidate on ESM would be to avoid accidentally duplicating versions of these components in apps which still use a mix of ESM and CommonJS. This is a pretty common footgun which results in increased bundle size as well as bugs when "stateful" things like context or settings are duplicated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with babel.config.js at the referenced target settings, then inspect the npm package paths under /components, /module/components, and /lib/components and the listed bundled files. Determine the supported browser targets and whether the package should consolidate on ESM; done means the agreed output formats and bundle set are updated without the unnecessary duplicates.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- babel, javascript, react
- Domain
- build-system, frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100