salesforce / salesforce/design-system-react
ColorPicker component has typescript errors for the methods in the event props
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
Our team uses SLDS react components in a typescript environment and we are seeing a few typescript errors on certain props in the ColorPicker component that uses event handlers. Issues are happening in the event props for the following event handlers: onChange, onClose, onOpen, onRequestClose, onWorkingColorChange. This is due to the types for those props only take in one parameter, e.g. onChange?: (v: any) => any; instead of having an additional event parameter for the handler. We recently fixed some other components in a seperate Issue/PR that was merged, here. This makes our linting tools fail in our CI/CD. Here are some snapshots of the error.


Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ColorPicker component and its TypeScript event-prop declarations, then compare the related fixes in issue/PR 2969. Update the types for onChange, onClose, onOpen, onRequestClose, and onWorkingColorChange so their signatures match the handlers, and verify that the reported TypeScript and linting errors are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100