salesforce / salesforce/design-system-react
Popovers propTypes/TS required children
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
PropTypes define Popovers as requiring children. However in instances like the GlobalHeader sub-components a body is not included.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Popovers component and its PropTypes and TypeScript definitions, then inspect the GlobalHeader sub-components that render it without a body. Confirm the intended behavior for childless instances and update the required-children declarations accordingly. Done means those usages no longer report children as required and the relevant checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100