salesforce / salesforce/design-system-react
Combobox findDOMNode is deprecated in StrictMode
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
I've run into this warning using the combobox with React 17. It appears that it was tackled previously with popovers. @interactivellama is the gist of this issue just replacing it with components reference? I'm assuming in this instance it's a utility or sub component of comobox.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the combobox implementation and its related popover components to locate the findDOMNode usage that produces the React 17 StrictMode warning. Compare the approach previously used for popovers, then verify that the combobox no longer emits the warning under StrictMode. No specific files or tests are named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100