salesforce / salesforce/design-system-react
Popovers should focus on first focusable element when opened.
Open
Nobody has claimed this yet.
accessibility
stale
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
The SLDS docs state:
When triggered, user focus should be placed on the first focusable element that isn't the close button. If the close button is the only focusable element, focus should be placed there
It doesn't seem like that's been implemented here?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the popover implementation and comparing its opening behavior with the SLDS popover focus requirement linked in the issue. Verify that focus moves to the first focusable element other than the close button, or to the close button when it is the only option, and add or update coverage for these cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100