salesforce / salesforce/design-system-react

GlobalHeaderButton - unnecessary <li>

Open
#2,786 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

global-header stale
Dominant language
JavaScript
Stars
982
Forks
440
Avg merge
1d 21h
Merged PRs (30d)
4

Description

Hi,
in GlobalHeaderButton the

  • is no longer (GlobalHeader has been probably refactored).

    Now it renders 2 nested

  • s for non-dropdown GlobalHeaderButtons.

    https://github.com/salesforce/design-system-react/blob/9bf11922023e46e85ecc07f6fb376938180a1bcc/components/global-header/button.jsx#L32

    • Contributor guide

    Open the contributing guide

    First steps

    1. Read the whole issue, then the project's contributing guide.
    2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
    3. Fork the repository and make your change on a branch.
    4. Open a pull request that references the issue number.

    Research direction

    Start at components/global-header/button.jsx around line 32 and inspect how GlobalHeaderButton renders its list item for non-dropdown buttons. Remove the unnecessary nested element so non-dropdown buttons no longer render two nested

  • elements, then verify the rendered markup against the issue description.

    • Written by the indexing model from the issue text.

    Assessment

    Tech stack
    javascript, react
    Domain
    frontend
    Issue type
    Bug
    Difficulty
    2/5
    Estimated time
    1-3 hours
    Activity status
    Stale
    Clarity
    Clearly specified
    Newbie friendliness
    45/100

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.