salesforce / salesforce/design-system-react
Popover classNameFooter prop is not respected when footerWalkthroughActions is specified
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
For a popover, specify both footerWalkthroughActions and classNameFooter. classNameFooter is not added as a class name to the .slds-popover__footer element, as the prop description says it does.
Popover without any special class name on the footer element:
Code, which species the classNameFooter:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Popover component and its handling of the footerWalkthroughActions and classNameFooter props. Reproduce the issue with both props, then verify the .slds-popover__footer element receives the requested class and add or update a regression test if the project has coverage for this behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100