salesforce / salesforce/design-system-react
Support menu item visible length in autocomplete combobox
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
Currently in Combobox we have
/**
* Determines the height of the menu based on SLDS CSS classes. This only applies to the readonly variant. This is a `number`.
*/
readOnlyMenuItemVisibleLength: PropTypes.oneOf([5, 7, 10]),
We should deprecated this property and make it menuItemVisibleLength and allow it to apply to autocomplete Comboboxes also.
Here is an example prop deprecation in App Launcher. https://github.com/salesforce/design-system-react/blob/master/components/app-launcher/index.jsx#L136
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Combobox implementation and compare the prop deprecation pattern in components/app-launcher/index.jsx. Trace how the existing readOnlyMenuItemVisibleLength prop is used, then verify that the replacement supports autocomplete as well as the readonly variant and that the old prop is deprecated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100