salesforce / salesforce/design-system-react

Update Combobox Lookup Examples to use pre-defined examples only

Open
#2,355 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

combobox mc-design-backlog
Dominant language
JavaScript
Stars
982
Forks
440
Avg merge
1d 21h
Merged PRs (30d)
4

Description

  • Since the vast majority of uses cases for Lookups are to search pre-defined options default all the examples to be pre-defined by default. It's okay to allow custom entries but we should not show it in the examples. I have never seen a situation where custom entries are permitted but it is something SLDS does allow.

  • Update Base-Pre-defined Options Only (http://design-system-react-components.herokuapp.com/?path=/story/sldscombobox--base-pre-defined-options-only): Per SLDS "The up and Down arrows should not update the input value to reflect the currently selected option. The input value should only be updated upon selection." The user should always be able to type in the input and it should never become locked.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Base-Pre-defined Options Only Storybook example linked in the issue and inspect the related Combobox examples. Compare their behavior with the stated SLDS rules: examples should use predefined options, arrow navigation should not change the input until selection, and typing should remain possible. Done means the examples demonstrate those behaviors without showing custom-entry use cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.