salesforce / salesforce/design-system-react
Remove Padding from Inline Edit Dialog
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
Per a recent discussion with the other SLDS Ambassadors, we'd like to remove the padding from the right/left side of the inputs and padding from the right side of the Save button.
Should text be needed on the top right side of an input for a character count additional adjustments will need to be made by dev teams to accommodate the margin on the close x so the text can be right-aligned. Adding a character count isn't something anyone is currently using so the extra space isn't needed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the inline edit dialog implementation and its styling to identify the input and Save button spacing described in the issue. Compare the rendered dialog with the attached image, remove the specified side padding, and verify that the resulting layout handles the stated character-count caveat.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- design, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100