salesforce / salesforce/design-system-react
Combobox: Update disabled menu item pattern
Open
Nobody has claimed this yet.
combobox
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
Feedback from SLDS pattern on disabled menu items
- disabled items should skip item being active
- Don't close menu on click of disabled items
- Do not disable items with Tooltip. These are non-selectable and don't close menu
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start at the Combobox entry point and trace disabled menu-item handling, then inspect any existing component tests. Done means disabled items cannot become active, clicking them leaves the menu open, and tooltip-marked non-selectable items remain enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100