salesforce / salesforce/design-system-react
Wrong weekday when isIsoWeekday is set
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
There's an issue with days labels when isIsoWeekday is set. For example 04.09.2019 is labeled as Thursday (should be labeled as Wednesday).
behavior can be checked in Storybook:
http://design-system-react-components.herokuapp.com/?path=/story/sldsdatepicker--iso-weekdays
When isIsoWeekday is not set everything is fine.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Storybook sldsdatepicker--iso-weekdays example and trace the date-labeling path when isIsoWeekday is set. Reproduce the 04.09.2019 case, compare it with the behavior when the option is unset, and consider the issue done when the date is labeled Wednesday in ISO mode without changing the non-ISO behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react, storybook
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100