salesforce / salesforce/design-system-react
Remove Modal manager and trigger files
Open
Nobody has claimed this yet.
maintenance-task
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
See https://github.com/salesforce/design-system-react/blob/master/components/modal/index.jsx#L226
// This section of code should be removed once trigger.jsx
// and manager.jsx are removed. They appear to have
// been created in order to do modals in portals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at components/modal/index.jsx around line 226, then inspect the referenced trigger.jsx and manager.jsx files and their usages. Remove the obsolete modal manager and trigger files and the marked section in index.jsx; done means no remaining references to those files and the modal code remains consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100