salesforce / salesforce/design-system-react

Breadcrumb: Overflow menu items should be blue. Button width is too wide

Open
#2,162 1 comment 0 reactions 1 assignee View on GitHub

@pulkonet is already working on this.

Since Jul 11, 2019.

bread-crumb
Dominant language
JavaScript
Stars
982
Forks
440
Avg merge
1d 21h
Merged PRs (30d)
4

Description

Item 1: Menu items are currently black text and do not seem to be picking up this CSS rule:
.slds-dropdown--actions a, .slds-dropdown_actions a

The class slds-dropdown_actions probably needs to be added to the Dropdown.

Item 2: Overflow button is more narrow in SLDS.
SLDS
Screen Shot 2019-07-10 at 11 28 49 PM

DSR
Screen Shot 2019-07-10 at 11 28 40 PM

See https://www.lightningdesignsystem.com/components/breadcrumbs/#With-Overflow

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.