Trial bar buttons need to be links

Open
#2,090 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, react
Domain
frontend

Research direction

Locate the Trial-Bar component and inspect how its buttons are rendered and styled. Verify the text color and link behavior against the issue screenshot and confirm that the resulting controls use the intended link or link component.

Written by the indexing model from the issue text.

Description

button trial-bar

Thank you for filing an issue!

Issue found in Trial-Bar component:

  • Text on buttons is blue. It should be white.
  • There should be a link/button or maybe a link component available.
Screen Shot 2019-06-20 at 9 53 14 PM

Please review the frequently asked questions such as:

Please include in your issue:

  • If you are working on the problem. Issues may be closed within 30 days if no one is assigned. Maintainers work on this project 20-30 hours per week and have their own prioritized backlog.
  • How to duplicate a bug. Line numbers or code to paste into the documentation site examples is helpful.
  • If you are a Salesforce employee. You should also create a duplicate work item in your internal ticket system and link to this issue.
  • If you plan to work on a new component. Please propose props after reviewing at newly written components and docs/codebase-overview.md.

For Salesforce platform questions, please visit https://success.salesforce.com, https://partners.salesforce.com, or https://salesforce.stackexchange.com

This project uses SLDS markup, but you should submit HTML/CSS issues to https://github.com/salesforce-ux/design-system.

Dominant language
JavaScript
Stars
982
Forks
440
Avg merge
1d 21h
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from salesforce/design-system-react

All issues in salesforce/design-system-react

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.