salesforce / salesforce/design-system-react
Review accessing state inside of setting state
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
Currently MenuDropdown and Combobox are accessing the current state this.state in order to set a new state.
The correct procedure should be to use a callback:
https://medium.com/@voonminghann/when-to-use-callback-function-of-setstate-in-react-37fff67e5a6c
this.setState((prevState) => ({
isOpen: !prevState.isOpen,
}));
Search for // eslint-disable-next-line react/no-access-state-in-setstate in order to fix this issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for // eslint-disable-next-line react/no-access-state-in-setstate and inspect the occurrences in MenuDropdown and Combobox. Replace state updates that read this.state with callback-based updates using the previous state, then confirm the search finds no remaining cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100