salesforce / salesforce/design-system-react
Update overflowBoundaryElement usage to use React's createPortal
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
Now that React 16 features can be used. Components should update to createPortal.
https://reactjs.org/docs/portals.html
This will simplify the Dialog code and remove the need for context explicit passing to Portal children.
This will also allow Enzyme testing out of the box.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching the repository for overflowBoundaryElement and the Dialog implementation, then read the React portals documentation linked in the issue. The work is complete when the relevant components use React's createPortal, Dialog no longer needs explicit context passing to Portal children, and Enzyme can test them without special handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100