salesforce / salesforce/design-system-react
npm run update-snapshot -- -u results in snapshot images diffs that aren't diff.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 982
- Forks
- 440
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 4
Description
Just wanted to see if I was the only one getting this:
When I run npm run update-snapshot -- -u, I get a bunch of diffs on .pngs snapshot images. When looking at the diff, there does not seem to be any changes. I've been discarding them before committing but I feel we should probably fix this since it's a manual step I'd like to avoid doing over an over.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with npm run update-snapshot -- -u and inspect the generated .pngs snapshot images and their diffs. Trace the snapshot update workflow to determine why unchanged images appear modified. Done means the command no longer produces false-positive image diffs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100