salesforce / salesforce/design-system-react

Make Tabs a controlled component

Open
#1,380 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking-change tabs
Dominant language
JavaScript
Stars
982
Forks
440
Avg merge
1d 21h
Merged PRs (30d)
4

Description

  • Make Tabs a controlled component (require parent to choose current tab by prop).
  • Update to current SLDS markup #1053
  • Remove DOM searches. Do not depend on DOM for state.
  • Allow Popovers and tooltips on tabs. #1186
Props
  • Add id to TabPanel and selectedId to Tabs.
  • Removed Index related props (considering allowing in a hidden backwards compatible way)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing Tabs and TabPanel components and reviewing their current props and SLDS markup. Implement the requested controlled Tabs API with TabPanel ids and selectedId, remove DOM-based state and index-related props, and verify that popovers and tooltips remain usable on tabs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.