salesforce / salesforce/cloudsplaining

Add policy minification?

Open
#209 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
2.2k
Forks
221
Avg merge
3h 21m
Merged PRs (30d)
8

Description

As brought up https://github.com/Netflix-Skunkworks/policyuniverse/issues/38#issuecomment-868751613 ... it would be pretty handy if cloudsplaining could help with that by considering adding a minimize-policy to accompany the existing expand-policy (which I am happy to learn exists).

A few thoughts:

  1. Like policyuniverse, I'd expect it to take the input policy into account in as much that it would determine the given actions/permissions and read/list/write/tag scope and stick with that? Meaning it wouldn't purely be doing pattern recognition wildcard replacement based on the given strings but take the related permissions potentially not included in the input policy into account; so there wouldn't be unintended permissions granted by mistake. That may be a given but I thought it should be said anyways.

  2. Maybe kind of a feature request/enhancement to the existing expand-policy functionality as well... it would be cool if the resulting policies could be auto split to work within the constraints of AWS's various policy character limits.

What originally sparked my curiosity in this area was to build a "Safer" ReadOnlyAccess policy. I believe @kmcquade you've thought about similar things at length. I'm curious about the best approaches. I understand this is off-topic to the OP/issue.

# Get the list of actions we want to remove into an array
ActionsToRemove=($(cloudsplaining scan-policy-file --input-file $Policy_Filename | grep Actions | sed 's/.*Actions.*: //Ig' | tr ' ' '\n' | tr -d ',' | sort | uniq))

# Remove each action determined to be a risk
for Action in "${ActionsToRemove[@]}"; do
    sed -i "/\"$Action\".*/Id" $Policy_Filename
done

And some ugly attempts at minizing that using policyuniverse:

# Concatenate Service/Actions
tee "$PolicyUniverseMinification" > /dev/null <<EOF
from policyuniverse.expander_minimizer import minimize_policy
policy = $(cat $Policy_Filename)
minimized_policy = minimize_policy(policy=policy, minchars=None)
print(minimized_policy)
EOF

# Remove missing actions; Blackhole actions: meaning Policy Universe does not have information on them...
until python $PolicyUniverseMinification 2> stderr.txt; do
    MissingAction=$(cat stderr.txt | grep "Exception: Desired action not found in master permission list." | cut -d. -f2 | sed 's/^[[:space:]]*//g')
    echo "Removing Blackhole action: '$MissingAction'..."
    sed -i "/\"$MissingAction\".*/Id" $PolicyUniverseMinification
done

vs. simply getting the output of cloudsplaining and adding it to a Deny statement I started questioning my approach.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing expand-policy functionality and the linked policyuniverse expander_minimizer example. Clarify whether the goal is a minimize-policy command, safer permission-aware minimization, policy splitting for AWS character limits, or all three; completion criteria are not defined in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, javascript, python
Domain
cli, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.