salesforce / salesforce/bazel-jdt-java-toolchain

Integrate Error Prone into ECJ

Open
#7 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
12
Forks
8
PR merge metrics
No merged PRs in 30d

Description

There are two possible approaches:

  1. Add abstraction into Error Prone to become independent of javac as described in https://github.com/google/error-prone/issues/11
  2. Build a bridge that translates from ECJ AST into javac classes and ensure Error Prone accepts those

We need to figure out what is the better strategy to go with. Having Error Prone integrated directly with ECJ would be nice because we are using ECJ as well in the Bazel Language Server (Eclipse and VS Code)

Error Prone is currently integrated in the Bazel Java Compiles via ErrorPronePlugin

/**
 * A plugin for BlazeJavaCompiler that performs Error Prone analysis. Error Prone is a static
 * analysis framework that we use to perform some simple static checks on Java code.
 */
public final class ErrorPronePlugin extends BlazeJavaCompilerPlugin {..}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked Error Prone issue #11 and the Bazel ErrorPronePlugin referenced in the issue. Compare the proposed Error Prone abstraction with the ECJ-to-javac bridge, including how each would support Bazel Language Server use; the work is done when a strategy is selected and its integration scope is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.