Latest commit broke previous fixes for handling optionalNamespaces

Open
#733 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
typescript
Domain
frontend

Research direction

Compare commits e7b8b2c18c3af1dc829e0ec49e7726cc22370fe9 and 6e79a23599a64e9917eb8bc4fd990a12970f2f08 from pull request 730, focusing on the optionalNamespaces handling. Reproduce the regression and confirm that the earlier fixes remain while the intended error-message changes are preserved.

Written by the indexing model from the issue text.

Description

Description

It seems that the last commit which should be only updating error messages:
https://github.com/safe-global/safe-react-apps/pull/730/commits/e7b8b2c18c3af1dc829e0ec49e7726cc22370fe9

accidentally rolled back previous fixes, like this one:
https://github.com/safe-global/safe-react-apps/pull/730/commits/6e79a23599a64e9917eb8bc4fd990a12970f2f08

Dominant language
TypeScript
Stars
116
Forks
84
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from safe-global/safe-react-apps

All issues in safe-global/safe-react-apps

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.