[WalletConnect] Send dapp's origin in the request

Open
#702 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
security, web-dev

Research direction

Start by tracing how the WalletConnect app constructs requests sent to the tx-service and how the current host is assigned as the origin. The work is done when the connected dapp origin, optionally alongside the WalletConnect origin, reaches the service without losing app usage analytics or preventing the proposed domain-based security checks.

Written by the indexing model from the issue text.

Description

Currently the WalletConnect app sends its host as the origin string. This makes the tx-service display a nice icon and the app's name in the history, but it's not very useful. Basically all non-Safe App transactions are either WalletConnect, or from the safe mobile apps, or direct contract interactions.

Screenshot 2023-05-23 at 11 15 11

It would be more useful to send the connected dapp's origin instead. Or in addition to the WC origin to keep the app usage analytics intact.

E.g. if you're connected to OpenSea, send opensea.io as the dapp origin. This will allow us to add domain-based security checks on the Safe wallet side.

Dominant language
TypeScript
Stars
116
Forks
84
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from safe-global/safe-react-apps

All issues in safe-global/safe-react-apps

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.