[Tx-builder] Check simulation call trace for reversion
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start in the Transaction Builder simulation flow and compare its call_trace error handling with the changes in web-core pull request 1861. Reproduce the four-step batch on Gnosis Chain, then verify that a simulation containing the described reversion is reported as unsuccessful rather than executable.
Written by the indexing model from the issue text.
Description
Description
Successful simulations can still revert. Not all errors from the call_trace are taken into account.
The changes included in web-core need to be added to the Transaction Builder as well.
Environment
- Browser: Firefox
- Wallet: MetaMask
- Safe:
gno:0x828cF988De33bf93527533852E95e2DA449Ec171 - Environment:
- prod/staging (Gnosis Chain)
Steps to reproduce
Open a 1.1.1 Safe on Gnosis Chain and create the following batch in the Transaction Builder:
toof current Safe,changeMasterCopyto0x3E5c63644E683549055b9Be8653de26E0B4CD36Etoof Current Safe,setMasterCopyto0xf48f2B2d2a534e402487b3ee7C18c33Aec0Fe5e4toof0x7a48Dac683DA91e4faa5aB13D91AB5fd170875bd,swapOwnertoof0x7a48Dac683DA91e4faa5aB13D91AB5fd170875bd,swapOwnerfrom to-be-added owner added in 3.
Simulate transaction and observe it succeeding, but upon execution failing.
Expected result
Simulation does not succeed.
Obtained result
Simulation succeeds.
Screenshots
- Dominant language
- TypeScript
- Stars
- 116
- Forks
- 84
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from safe-global/safe-react-apps
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
safe-global/safe-react-apps#863 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
safe-global/safe-react-apps#854 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
safe-global/safe-react-apps#852 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
safe-global/safe-react-apps#839 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
safe-global/safe-react-apps#835 ·
All issues in safe-global/safe-react-apps
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
vercel/react-tweet#225 ·