Improve e2e tests with Cypress

Open
#483 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cypress, typescript
Domain
ci-cd, testing

Research direction

Start by tracing the Cypress e2e flow, the cy.acceptCookiesAndSecurityFeedbackModal() command, and the deploy/e2e execution configuration. Check how test results and failures are currently reported in pull requests. Done means failures provide accurate feedback without blocking merges, the new localStorage-based command exists alongside the current one, and deployment and e2e runs use the intended order.

Written by the indexing model from the issue text.

Description

effort-low Enhancement ✨

Overview

We are gathering in this tickets several improvements that should be addressed in the current e2e flow

Requirements

  • e2e action result in PRs

Currently the e2e action always ends with a succesfully execution giving the sensation the tests had passed. We need to show the corrrect feedback but continue to allow the PR to be merged when the tests are failing:

image image
  • New command to improve cy.acceptCookiesAndSecurityFeedbackModal()

The current approach is about click the buttons until the cookies and modal are dismissed. A better approach should be create the localStorage items necessary to avoid the banner and modal to be showed.

We will create a new command and maintain the current one as is useful for some tests.

  • Create precedence between deploy and e2e execution

We need to create a precedence between the deploy action and the e2e execution for avoid running the tests against the wrong sites the first time we create a PR or make a merge to the main branches

Dominant language
TypeScript
Stars
116
Forks
84
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from safe-global/safe-react-apps

All issues in safe-global/safe-react-apps

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.