[Tx-builder] Research how callback types work on solidity

Open
#461 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
solidity, typescript
Domain
blockchain

Research direction

Start by reproducing the issue in the Tx Builder app on Rinkeby with contract 0xD7b9B6c7DC7F95F06e1Bc1e7894530b066EB23 and its testFunctionValue method, using the version from pull request #445. Research how Solidity function types are represented and handled, then determine whether the type should be supported. Done means the behavior is understood and the type is implemented if appropriate.

Written by the indexing model from the issue text.

Description

Bug 🐛

Description

function type methods are not working correctly as expected on the tx-builder and we should research why and implement them if necessary

Steps to reproduce

  1. Go to Tx Builder app on Rinkeby (to a version of it including these changes https://github.com/safe-global/safe-react-apps/pull/445)
    With this contract 0xD7b9B6c7DCbC7F95F06e1Bc1e7894530b066EB23 play around with testFunctionValue method.

Expected result

Investigate if this is a valid data type that we should allow on the tx-builder & implement it if needed.

Obtained result

Method is not working.

Screenshot 2022-06-15 at 16 15 03

Dominant language
TypeScript
Stars
116
Forks
84
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from safe-global/safe-react-apps

All issues in safe-global/safe-react-apps

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.