SIGTERM not handled
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 115
- Forks
- 23
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 3
Description
I run github-webhook as PID 1 inside a Docker container and the process does not terminate cleanly when it receives a SIGTERM. If I understand well node forwards the signals it receives, which makes me assume github-webhook does not handle them properly.
As a result the container is killed after a timeout (30sec in my infrastructure).
More about the subject: https://github.com/nodejs/node-v0.x-archive/issues/9131#issuecomment-72900581
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing github-webhook as PID 1 inside a Docker container and observe its behavior when it receives SIGTERM. Trace the process signal handling and verify that the container terminates cleanly without waiting for the 30-second timeout.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, javascript
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100