ruvnet / ruvnet/ruflo

Fix ESLint errors blocking CI/CD Pipeline

Open
#726 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
72.7k
Forks
8.6k
Avg merge
2d 23h
Merged PRs (30d)
83

Description

## Description
The linting check is failing due to multiple ESLint errors that need to be addressed.

## Key ESLint Errors (must fix)
### Unused Variables and Imports
- Multiple instances of unused variables, imports, and function parameters across files:
- src/agents/agent-registry.ts: 'AgentId' is defined but never used
- src/api/claude-client.ts: 'getErrorMessage' is defined but never used
- src/cli/agents/analyst.ts: Multiple 'data' variables assigned but never used
- src/cli/agents/index.ts: 'generateId' is defined but never used
- Many more similar issues

### Case Declaration Issues
- src/api/claude-client-enhanced.ts: Line 487 - Unexpected lexical declaration in case block
- src/api/claude-client.ts: Line 659 - Unexpected lexical declaration in case block

### Other Critical Errors
- Multiple files with unused function parameters that don't follow the underscore convention
- Numerous TypeScript type issues with 'any' types (warnings, but should be addressed)

## Files with Most Errors
1. src/cli/commands/advanced-memory-commands.ts
2. src/cli/agents/analyst.ts
3. src/cli/agents/coder.ts
4. src/cli/agents/tester.ts
5. src/cli/commands/agent-simple.ts

## Related Information
- PR: https://github.com/KHAEntertainment/claude-flow/pull/7
- Comment: https://github.com/KHAEntertainment/claude-flow/pull/7#issuecomment
- Requested by: @KHAEntertainment

## Recommended Actions
1. Run `npm run lint` locally to see all errors
2. Fix all ESLint errors (not just warnings)
3. Consider updating ESLint rules if some are too strict
4. Add proper underscore prefixes for intentionally unused parameters
5. Remove or utilize all unused imports and variables

Contributor guide

Open the contributing guide

Research direction

Run `npm run lint` locally and review the reported errors, starting with the listed files such as src/cli/commands/advanced-memory-commands.ts and src/cli/agents/analyst.ts. Address the unused imports, variables, parameters, and case declaration issues described in the report. Done means the lint command passes without errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.