ruvnet / ruvnet/ruflo

ADR-122 Phase 0 is marked shipped but ruflo doctor never reports agent-browser

Open
#3,166 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
72.7k
Forks
8.6k
Avg merge
2d 23h
Merged PRs (30d)
83

Description

## Summary

ADR-122 Phase 0 requires `ruflo doctor` to report the installed `agent-browser` version and warn below 0.27. The ADR tracking issue, #2041, was closed with all phases described as complete and `@claude-flow/browser@3.0.0-alpha.4` published, but the doctor acceptance item is still absent from current `main` and from the published CLI I verified.

This is a narrow acceptance-gap report. The package upgrade itself **did** land; this is not a claim that ADR-122 as a whole is unimplemented.

## Current-source evidence

- ADR-122 still states the acceptance criterion at [`v3/docs/adr/ADR-122-browser-beyond-sota.md:171`](https://github.com/ruvnet/ruflo/blob/db4991967c45c6f72133dff0bb80b0a492960fc1/v3/docs/adr/ADR-122-browser-beyond-sota.md#L159-L173).
- The current [`doctor.ts`](https://github.com/ruvnet/ruflo/blob/db4991967c45c6f72133dff0bb80b0a492960fc1/v3/%40claude-flow/cli/src/commands/doctor.ts) has no `agent-browser` or browser-runtime check.
- The current browser package is alpha.4 and does carry `agent-browser:^0.27.0`, confirming that the dependency-bump part landed: [`package.json`](https://github.com/ruvnet/ruflo/blob/db4991967c45c6f72133dff0bb80b0a492960fc1/v3/%40claude-flow/browser/package.json).

Source commit checked: `db4991967c45c6f72133dff0bb80b0a492960fc1`.

## Runtime verification

Environment:

- Ruflo `3.38.21`
- macOS arm64
- `agent-browser` absent from `PATH`

Running `ruflo doctor` exited 0 but emitted no `agent-browser` row, version, absence warning, or browser-integration diagnostic.

## Expected

`ruflo doctor` should report at least:

- whether `agent-browser` is on `PATH`;
- its parsed version when available;
- a warning when absent or below the supported minimum;
- which Ruflo browser surface depends on it.

The check should remain local and bounded. It does not need to launch Chrome or call `agent-browser doctor`.

## Actual

The browser package and MCP integration can depend on `agent-browser`, but core doctor does not expose that dependency's presence or version.

## Existing-issue review

- #2041 is the closed ADR tracker that declared all phases complete; this report pins its still-unmet Phase 0 acceptance item.
- #975 is the broad original integration request.
- #1605 fixed unconditional browser-tool registration when the binary is absent.
- #2912 concerns the separate `/ruflo-browser doctor` plugin smoke script and its installed-path bug.

None currently tracks the missing core `ruflo doctor` acceptance behavior.

## Acceptance

- Tests cover absent, supported, below-minimum, and unparsable version output.
- `ruflo doctor` output names the dependency and actionable remediation.
- The check does not launch a browser, perform network I/O, or mutate agent-browser daemon state.
- ADR-122 status/phase accounting is reconciled with the shipped state.

Contributor guide

Open the contributing guide

Research direction

Start with v3/@claude-flow/cli/src/commands/doctor.ts and the ADR-122 acceptance criterion at v3/docs/adr/ADR-122-browser-beyond-sota.md:171. Run ruflo doctor with agent-browser absent, supported, below-minimum, and unparsable version output, then add coverage for those cases. Done means the output identifies the dependency, version state, and remediation without launching a browser or performing network I/O.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.