rustsec / rustsec/advisory-db

CI failed to detect leftover placeholder link

Open
#1,959 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
1.2k
Forks
544
Avg merge
1d 10h
Merged PRs (30d)
45

Description

In #1947 and #1958 I botched, failing to update the `url=`` from the template

I have fixed it now, but I notice that the CI passed. I think it would have been nice if the CI had failed, pointing out my mistake.

Presumably a simialr issue could arise with the other fields. (Maybe the template and example would need to have some of the example values changed to more-invalid ones, to do this thoroughly.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the CI validation related to the advisory template, using issues #1947 and #1958 as examples of the missed placeholder. Check how the `url=`` value and other template fields are validated. Done means malformed leftover placeholder values cause CI to fail with a useful indication.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.