rustsec / rustsec/advisory-db

retain_mut is deprecated

Open
#1,929 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
1.2k
Forks
544
Avg merge
1d 10h
Merged PRs (30d)
45

Description

As described in the README, retain_mut has been deprecated with the release of Rust 1.61, which stabilized Vec::retain_mut and VecDeque::retain_mut.

I see this crate still makes peaks of 30k downloads a day, with Rust 1.61 having been released almost 2 years ago. Should an advisory be made for it?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the README reference to retain_mut and the linked Rust 1.61 documentation for Vec::retain_mut and VecDeque::retain_mut. Assess whether this deprecation fits the advisory database's scope; done means reaching and recording a clear decision about whether an advisory should be made.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.