Wrap TrustAnchor array items in AsRef<T>
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 160
- Forks
- 102
- Avg merge
- 28m
- Merged PRs (30d)
- 5
Description
There are some places that take a borrowed array of owned TrustAnchors e.g.,
E.g.,
https://github.com/rustls/webpki/blob/34e8f9ecc811ea678a3a7eef8db3a2974f4628bb/src/verify_cert.rs#L39
https://github.com/rustls/webpki/blob/2879b2ce7a476181ac3050f73fe0835f04728e86/src/end_entity.rs#L106
I believe the array sub-type can be wrapped in AsRef in many of these cases e.g.,
trust_anchors: &'p [AsRef<TrustAnchor<'_>>],
In some of the uses, the implementation doesn't seem to actually need ownership of the TrustAnchor and just reads from it a bit. Optionally accepting a borrowed reference should be helpful for cases e.g., where one or more of the TrustAnchors are cached and re-used.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the TrustAnchor uses in src/verify_cert.rs and src/end_entity.rs, then search the repository for other borrowed arrays of owned TrustAnchors. Check which callers require ownership versus only borrowed access; done means the applicable APIs accept reusable borrowed TrustAnchors without breaking existing owned callers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100