rustls / rustls/webpki

Clean up overuse of BadDer

Open
#38 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
160
Forks
102
Avg merge
28m
Merged PRs (30d)
5

Description

in quite a number of places we use Error::BadDer as a generic error code. i think we should be reserving it for genuine bad DER encoding cases and introducing more specific errors where the DER encoding is OK but the contents/semantics of the encoding are wrong.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating every use of Error::BadDer and review the surrounding certificate-validation paths. Determine which cases involve malformed DER versus valid DER with invalid contents or semantics; the work is done when genuine encoding failures retain BadDer and the other cases use appropriately specific errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.