rustls / rustls/webpki

Consider using `Borrow`/`ToOwned` instead of `From`/`AsRef` for `DnsName` (and `SubjectName`)

Open
#23 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
160
Forks
102
Avg merge
28m
Merged PRs (30d)
5

Description

I think these have more meaningful semantics and are potentially useful when used in, for example, a HashMap.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the DnsName and SubjectName definitions and their existing From and AsRef implementations. Investigate whether Borrow and ToOwned provide the intended semantics for HashMap use; done means reaching a clear API decision and updating the affected trait implementations consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.