rustls / rustls/rustls-platform-verifier
Can I optimize this on Android?
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 158
- Forks
- 60
- Avg merge
- 5d 10h
- Merged PRs (30d)
- 3
Description
I found https cost more time on rust than java, then I found function verifyCertificateChain cost most time
CertificateVerifier.kt
Log.d(TAG, "verifyCertificateChain PKIXBuilderParameters start")
val parameters = PKIXBuilderParameters(keystore, null)
Log.d(TAG, "verifyCertificateChain PKIXBuilderParameters end")
it cost 200ms every request
If change it, we can save time
var trustAnchors = HashSet<TrustAnchor>()
validChain.forEach {
trustAnchors.add(TrustAnchor(it, null));
}
var pkixParameters = PKIXParameters(trustAnchors)
pkixParameters.certPathCheckers = listOf(revocationChecker)
pkixParameters.isRevocationEnabled = false
validator.validate(certFactory.generateCertPath(validChain), pkixParameters)
I have already try and it did work, so can we do this?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in CertificateVerifier.kt at verifyCertificateChain and inspect the PKIXBuilderParameters setup and subsequent certificate validation. Compare the proposed trust-anchor and PKIXParameters approach, then verify that certificate-chain validation remains correct while avoiding the reported per-request cost.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin, rust
- Domain
- mobile-dev, performance, security
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100