rustls / rustls/rustls-platform-verifier

with_extra_roots extension

Open
#202 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement O-Apple O-UNIX O-Windows
Dominant language
Rust
Stars
158
Forks
60
Avg merge
5d 10h
Merged PRs (30d)
3

Description

Currently to use extra roots I need to use the following setup:

builder.dangerous()
    .with_custom_certificate_verifier(Arc::new(Verifier::new_with_extra_roots(extra_roots)?))

There exists the ext trait which could be extended to support:

builder.with_platform_verifier_and_extra_roots(extra_roots)?

This avoids needing to justify the use of dangerous when setting up TLS. This mirrors the non-dangerous with_root_certificates method.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the extension trait in rustls-platform-verifier/src/lib.rs and compare the requested API with rustls ConfigBuilder::with_root_certificates. Confirm the work is complete when the trait supports with_platform_verifier_and_extra_roots(extra_roots) without requiring dangerous(), with the existing verifier behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.