rustls / rustls/rustls-ffi

rustls_client_config_builder_new: use the default set if cipher_suites is NULL

Open
#163 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
170
Forks
43
Avg merge
1d 1h
Merged PRs (30d)
10

Description

I'm having trouble building an array of ciphersuites in C because I don't know C very well and keep being told I'm either discarding the 'const' qualifier from the pointer target type or trying to assign to a constant pointer, and so I keep getting in trouble.

Anyway all I am trying to do is use the default set of cipher suites. It would be nice if rustls_client_config_builder_new could check for null in the cipher_suites argument, and then just use the default set of ciphersuites.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the rustls_client_config_builder_new entry point and trace how its cipher_suites argument is handled. Verify that a NULL argument selects the default cipher-suite set while supplied suites retain their current behavior, then check the repository’s existing coverage for this API.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, rust
Domain
cryptography, security
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.