rustls / rustls/rustls-bench-app
Don't wait for PR approval when PR author is a maintainer
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
An idea from djc in discord:
would be nice if the benchmarking bot knew it doesn't need to wait for approval on PRs where the author is an org maintainer
I think this would be a fairly small lift: we already have the code in place to check when a PR is approved that the approver has an allowed account association. Likely we just need to adjust the event processing for a new PR to skip requiring an approval or a comment if the author has such an association.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read ci-bench-runner/src/job/bench_pr.rs, especially the existing allowed account association check at lines 29-36, then trace the event processing for a new PR. The change is complete when PRs authored by an organization maintainer no longer require approval or a comment before benchmarking, while other PRs retain the current behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- ci-cd
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100