rustdesk / rustdesk/rustdesk-server

Do not require s6 container to run as root

Open
#424 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
10.4k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

The classic containers work perfectly fine when running them as an unprivileged user (user: nobody:nobody or similar in the compose file).

However, in the s6 container this does not work out of the box, making /data a volume pointing to a directory owned and writable by that particular user fixes it, but the chown root:root ... calls for the secrets still fail (not a problem though).

It would be nice if those commands were skipped when not running as root.

I think it would make sense in any case to default to NOT running hbbs/hbbr as root, since they do not seem to need such privileges.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the s6 container startup commands and the compose configuration that sets the container user. Check how startup handles the /data volume and secret chown calls for an unprivileged user; done means the s6 container starts without root and does not fail on root-only ownership commands.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, docker-compose
Domain
devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.