rustdesk / rustdesk/rustdesk-server
add password to hbbr
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 10.4k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Hello all,
I want to implement password protection on the hbbr.
My Idea is to add a password field here :
https://github.com/rustdesk/rustdesk-server/blob/1f7d3fa05ce6c8b3198a29a4a5a8095419608fe3/libs/hbb_common/protos/rendezvous.proto#L99-L108
And to do a comparison here and just return if hash is not matched :
https://github.com/rustdesk/rustdesk-server/blob/1f7d3fa05ce6c8b3198a29a4a5a8095419608fe3/src/relay_server.rs#L428-L457
Am I missing something ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with libs/hbb_common/protos/rendezvous.proto at the referenced field range, then trace the relay handling in src/relay_server.rs around lines 428-457. Determine how the password field is carried to hbbr and how a hash mismatch should cause the request to return. Done means hbbr supports password protection with unmatched hashes rejected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100