rustdesk / rustdesk/rustdesk-server-pro

Unable to edit devices with an ID below 6 charatcers

Open
#764 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Shell
Stars
317
Forks
119
PR merge metrics
No merged PRs in 30d

Description

Bug Description

We use allow-hostname-as-id=Y on all our devices, but if the device has a hostname that is less than 6 characters you will not be able to edit the device inside an address book.

See example:

Image
How to Reproduce
  1. Have a device with a hostname less than 6 characters
  2. Create a custom application with allow-hostname-as-id=Y
  3. Try to edit this device inside an address book (ex. adding an alias or password)
Expected Behavior

I expected to be allowed to edit the device.

Operating system(s) on local (controlling) side and remote (controlled) side

N/A

RustDesk Version(s) on local (controlling) side and remote (controlled) side

N/A

Screenshots
Image
Additional Context

Running RustDesk Server Pro 1.6.3

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by creating a custom application with allow-hostname-as-id=Y, using a hostname shorter than six characters, and editing that device in an address book. No source file or test is named, so first trace the address-book device-edit entry point and its handling of short hostnames; done means aliases and passwords can be edited successfully.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.